Merge pull request #88 from sellensr/master

Index checksum explicitly on $ and *

Adafruit_GPS.cpp

@@ -57,18 +57,21 @@ boolean Adafruit_GPS::parse(char *nmea) {
   // do checksum check
 
   // first look if we even have one
-  size_t len = strlen(nmea);
+  char *ast = strchr(nmea,'*');
-  if (nmea[len-5] == '*') {
+  if (ast != NULL) {
-    uint16_t sum = parseHex(nmea[len-4]) * 16;
+    uint16_t sum = parseHex(*(ast+1)) * 16;
-    sum += parseHex(nmea[len-3]);
+    sum += parseHex(*(ast+2));
-
     // check checksum
-    for (uint8_t i=1; i < (len-5); i++) {
+    char *p = strchr(nmea,'$');
-      sum ^= nmea[i];
+    if(p == NULL) return false;
-    }
+    else{ 
-    if (sum != 0) {
+      for (char *p1 = p+1; p1 < ast; p1++) {
-      // bad checksum :(
+        sum ^= *p1;
-      return false;
+      }
+      if (sum != 0) {
+        // bad checksum :(
+        return false;
+      }
     }
   } else {
   	return false;