From c41e829dcc8a849d3a22b6f823e8508c3bc52d21 Mon Sep 17 00:00:00 2001 From: Walt Date: Thu, 10 Mar 2022 21:43:30 -0800 Subject: [PATCH 1/2] write method parameter const-ness fix https://github.com/adafruit/Adafruit_FRAM_SPI/issues/25 --- Adafruit_SPIDevice.cpp | 6 +++--- Adafruit_SPIDevice.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Adafruit_SPIDevice.cpp b/Adafruit_SPIDevice.cpp index fdd50c0..4f6eca9 100644 --- a/Adafruit_SPIDevice.cpp +++ b/Adafruit_SPIDevice.cpp @@ -295,8 +295,8 @@ void Adafruit_SPIDevice::endTransaction(void) { * @return Always returns true because there's no way to test success of SPI * writes */ -bool Adafruit_SPIDevice::write(uint8_t *buffer, size_t len, - uint8_t *prefix_buffer, size_t prefix_len) { +bool Adafruit_SPIDevice::write(const uint8_t *buffer, size_t len, + const uint8_t *prefix_buffer, size_t prefix_len) { if (_spi) { _spi->beginTransaction(*_spiSetting); } @@ -402,7 +402,7 @@ bool Adafruit_SPIDevice::read(uint8_t *buffer, size_t len, uint8_t sendvalue) { * @return Always returns true because there's no way to test success of SPI * writes */ -bool Adafruit_SPIDevice::write_then_read(uint8_t *write_buffer, +bool Adafruit_SPIDevice::write_then_read(const uint8_t *write_buffer, size_t write_len, uint8_t *read_buffer, size_t read_len, uint8_t sendvalue) { if (_spi) { diff --git a/Adafruit_SPIDevice.h b/Adafruit_SPIDevice.h index 8de31d0..a6bf462 100644 --- a/Adafruit_SPIDevice.h +++ b/Adafruit_SPIDevice.h @@ -77,9 +77,9 @@ public: bool begin(void); bool read(uint8_t *buffer, size_t len, uint8_t sendvalue = 0xFF); - bool write(uint8_t *buffer, size_t len, uint8_t *prefix_buffer = NULL, + bool write(const uint8_t *buffer, size_t len, const uint8_t *prefix_buffer = NULL, size_t prefix_len = 0); - bool write_then_read(uint8_t *write_buffer, size_t write_len, + bool write_then_read(const uint8_t *write_buffer, size_t write_len, uint8_t *read_buffer, size_t read_len, uint8_t sendvalue = 0xFF); bool write_and_read(uint8_t *buffer, size_t len); From b6f7b3abe1be0df544534324ed2046c26912f0e8 Mon Sep 17 00:00:00 2001 From: Walt Date: Mon, 14 Mar 2022 22:45:53 -0700 Subject: [PATCH 2/2] applied clang-format --- Adafruit_SPIDevice.cpp | 3 ++- Adafruit_SPIDevice.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Adafruit_SPIDevice.cpp b/Adafruit_SPIDevice.cpp index 4f6eca9..55298f7 100644 --- a/Adafruit_SPIDevice.cpp +++ b/Adafruit_SPIDevice.cpp @@ -296,7 +296,8 @@ void Adafruit_SPIDevice::endTransaction(void) { * writes */ bool Adafruit_SPIDevice::write(const uint8_t *buffer, size_t len, - const uint8_t *prefix_buffer, size_t prefix_len) { + const uint8_t *prefix_buffer, + size_t prefix_len) { if (_spi) { _spi->beginTransaction(*_spiSetting); } diff --git a/Adafruit_SPIDevice.h b/Adafruit_SPIDevice.h index a6bf462..7fe0999 100644 --- a/Adafruit_SPIDevice.h +++ b/Adafruit_SPIDevice.h @@ -77,8 +77,8 @@ public: bool begin(void); bool read(uint8_t *buffer, size_t len, uint8_t sendvalue = 0xFF); - bool write(const uint8_t *buffer, size_t len, const uint8_t *prefix_buffer = NULL, - size_t prefix_len = 0); + bool write(const uint8_t *buffer, size_t len, + const uint8_t *prefix_buffer = NULL, size_t prefix_len = 0); bool write_then_read(const uint8_t *write_buffer, size_t write_len, uint8_t *read_buffer, size_t read_len, uint8_t sendvalue = 0xFF);